Add DialogHeader to lab #4298
Merged
Add DialogHeader to lab #4298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 144a35d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Fercas123
commented
Oct 16, 2024
Fercas123
commented
Oct 17, 2024
origami-z
reviewed
Oct 17, 2024
Fercas123
force-pushed
the
dialog-header
branch
from
e2f61e5
to
45a82d8
Compare
Fercas123
force-pushed
the
dialog-header
branch
from
f20268c
to
8803846
Compare
joshwooding
reviewed
Oct 21, 2024
joshwooding
reviewed
Oct 21, 2024
joshwooding
reviewed
Oct 21, 2024
Fercas123
force-pushed
the
dialog-header
branch
from
47221d0
to
7d332ad
Compare
Fercas123
added
the
chromatic
github-actions
bot
removed
the
chromatic
Fercas123
force-pushed
the
dialog-header
branch
from
7d332ad
to
b5bef67
Compare
Fercas123
added
the
chromatic
github-actions
bot
removed
the
chromatic
amritadesmet
previously approved these changes
Nov 8, 2024
origami-z
reviewed
Nov 8, 2024
There was a problem hiding this comment.
Code looks fine. Will tick once Nav reviewed this.
I think we need to talk about migration path (ad code diff vs current approach) for the user around it. Is it true that the only/major change is the additionally actions prop? If so, when this works, I guess we're not moving this lab header to core, but rather deprecate DialogActions in core and add actions prop to the existing Dialog header?
Fercas123
added
the
chromatic
navkaur76
approved these changes
Nov 8, 2024
github-actions
bot
removed
the
chromatic
origami-z
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.